potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352731417
########## File path: airflow/executors/base_executor.py ########## @@ -16,67 +14,86 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. - +""" +Base executor - this is the base class for all the implemented executors. +""" from collections import OrderedDict +from typing import Any, Dict, List, Optional, Set, Tuple, Union -# To avoid circular imports -import airflow.utils.dag_processing -from airflow.configuration import conf Review comment: I think it makes no real difference as we discussed before. And i actually (in the further commit) made a check to use it consistently 'from airflow import conf' and 'LoggingMixin' in as many places as possible (there are just a few exception where it matters - mainly around configuration itself and plugin manager. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
