potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle
Executors class to avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#discussion_r352743665
##########
File path: airflow/executors/kubernetes_executor.py
##########
@@ -241,17 +253,23 @@ def _validate(self):
class KubernetesJobWatcher(multiprocessing.Process, LoggingMixin):
"""Watches for Kubernetes jobs"""
- def __init__(self, namespace, watcher_queue, resource_version,
worker_uuid, kube_config):
+ def __init__(self,
+ namespace: str,
+ watcher_queue: 'Queue[KubernetesWatchType]',
+ resource_version: str,
+ worker_uuid: Optional[str],
+ kube_config: Configuration):
multiprocessing.Process.__init__(self)
- self.namespace = namespace
- self.worker_uuid = worker_uuid
- self.watcher_queue = watcher_queue
- self.resource_version = resource_version
- self.kube_config = kube_config
+ self.namespace: str = namespace
Review comment:
True, I was a bit over-protective here :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
