o-nikolas commented on code in PR #60158: URL: https://github.com/apache/airflow/pull/60158#discussion_r2669406734
########## contributing-docs/05_pull_requests.rst: ########## @@ -100,6 +100,31 @@ these guidelines: - Adhere to guidelines for commit messages described in this `article <https://cbea.ms/git-commit/>`__. This makes the lives of those who come after you (and your future self) a lot easier. +Gen-AI Assisted contributions +----------------------------- + +Generally, it's fine to use Gen-AI tools to help you create Pull Requests for Apache Airflow as long as you +adhere to the following guidelines: + +* Follow the `Apache Software Foundation (ASF) Generative Tooling guideliens <https://www.apache.org/legal/generative-tooling.html>`__. +* Ensure that you review and understand all code generated by Gen-AI tools before including it in your PR - + do not blindly trust the generated code. +* Make sure that the generated code adheres to the project's coding standards and best practices described + above +* Make sure to run all relevant static checks and tests locally to verify that the generated code works as + intended and does not introduce any issues. +* State in your PR description that you have used Gen-AI tools to assist in creating the PR. +* Be prepared to explain and justify the use of Gen-AI tools if asked by project maintainers or reviewers. +* Remember that the final responsibility for the code in your PR lies with you, regardless of whether + it was generated by a tool or written by you. +* By contributing code generated by Gen-AI tools, you agree to comply with the project's licensing terms + and any applicable laws and regulations. +* Blindly copy & pasting code from Gen-AI tools is detrimental as it might introduce security and +stability risks to the project. Maintainers that spot such behaviours will have no choice but to +close the related PRs. It adds extra burden on the maintainers and doesn't help the project. +The contributor reputation is also impacted as maintainers will lose confidence and might block +the user from making further contributions. Review Comment: This feels like it might not be necessary. But also doesn't hurt. ########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -1,44 +1,35 @@ <!-- - Licensed to the Apache Software Foundation (ASF) under one - or more contributor license agreements. See the NOTICE file - distributed with this work for additional information - regarding copyright ownership. The ASF licenses this file - to you under the Apache License, Version 2.0 (the - "License"); you may not use this file except in compliance - with the License. You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - - Unless required by applicable law or agreed to in writing, - software distributed under the License is distributed on an - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - KIND, either express or implied. See the License for the - specific language governing permissions and limitations - under the License. - --> +Thank you for contributing! -<!-- -Thank you for contributing! Please make sure that your code changes -are covered with tests. And in case of new features or big changes -remember to adjust the documentation. +Please provide above a brief description of the changes made in this pull request. +Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ + +Please make sure that your code changes are covered with tests. +And in case of new features or big changes remember to adjust the documentation. -Feel free to ping committers for the review! +Feel free to ping (in general) for the review if you do not see reaction for a few days +(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: -closes: #ISSUE -related: #ISSUE +* closes: #ISSUE +* related: #ISSUE +--> + +## Was generative AI tooling used to co-author this PR? -How to write a good git commit message: -http://chris.beams.io/posts/git-commit/ +<!-- +If generative AI tooling has been used in the process of authoring this PR, please +change below checkbox to `[X]` followed by the name of the tool. --> +- [ ] Yes (please specify the tool below) +Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) Review Comment: Why are we concerned with what the tool is? Is that critical information or more of a frustrating data entry for those of us who regularly commit? Also is it just the tool that we want to know about? Or the model itself? I would think the model is more relevant? I think something simpler like this would be better: ``` <!-- If generative AI tooling has been used in the process of authoring this PR, please change the below checkbox to `[X]` to confirm the usage followed the [Gen AI project guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> - [ ] Yes, Gen AI was used and I confirm that the usage followed project guidelines. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
