potiuk commented on code in PR #60158: URL: https://github.com/apache/airflow/pull/60158#discussion_r2669578820
########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -1,44 +1,35 @@ <!-- - Licensed to the Apache Software Foundation (ASF) under one - or more contributor license agreements. See the NOTICE file - distributed with this work for additional information - regarding copyright ownership. The ASF licenses this file - to you under the Apache License, Version 2.0 (the - "License"); you may not use this file except in compliance - with the License. You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - - Unless required by applicable law or agreed to in writing, - software distributed under the License is distributed on an - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - KIND, either express or implied. See the License for the - specific language governing permissions and limitations - under the License. - --> +Thank you for contributing! -<!-- -Thank you for contributing! Please make sure that your code changes -are covered with tests. And in case of new features or big changes -remember to adjust the documentation. +Please provide above a brief description of the changes made in this pull request. +Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ + +Please make sure that your code changes are covered with tests. +And in case of new features or big changes remember to adjust the documentation. -Feel free to ping committers for the review! +Feel free to ping (in general) for the review if you do not see reaction for a few days +(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: -closes: #ISSUE -related: #ISSUE +* closes: #ISSUE +* related: #ISSUE +--> + +## Was generative AI tooling used to co-author this PR? -How to write a good git commit message: -http://chris.beams.io/posts/git-commit/ +<!-- +If generative AI tooling has been used in the process of authoring this PR, please +change below checkbox to `[X]` followed by the name of the tool. --> +- [ ] Yes (please specify the tool below) +Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) Review Comment: That's a good point and I already removed version (copied it from Spark template). This is mostly about potential legal repercussions. And it's taken directly from: https://www.apache.org/legal/generative-tooling.html > When providing contributions authored using generative AI tooling, a recommended practice is for contributors to indicate the tooling used to create the contribution. This should be included as a token in the source control commit message, for example including the phrase “Generated-by: ”. This allows for future release tooling to be considered that pulls this content into a machine parsable Tooling-Provenance file. So we are strictly following Guidelines of the ASF. And yes - it is ambiguous and left to discretion of people what they provide there, and I think that's ok. Yes, it adds a bit of friction, but also I think some level of reasonable friction is open-source is actually a very good thing. This will make some people pause and think what they used - and maybe even double check what their configuration is, and maybe even they will start asking questions about their tooling - which might be actually better than hiding that they are using something. There is a great talk about dangers to open-source which I watched recently - on how sustainability of OSS is endangered now, where one of the reasons is that our tooling is "too easy" for people to participate and that creates a lot of troubles for maintainers, and adding some reasonable friction which make people start thinking and having to make choices, is a good thing. I highly recommend that one - https://media.ccc.de/v/39c3-how-to-keep-open-source-open-without-leaving-our-communities-open-to-threats - in fact I am signing up to the working group mentioned there to discuss and probably come up with some blueprints and patterns in the open-source on how to keep OSS sustainable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
