potiuk commented on code in PR #60158: URL: https://github.com/apache/airflow/pull/60158#discussion_r2670010128
########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -1,44 +1,35 @@ <!-- - Licensed to the Apache Software Foundation (ASF) under one - or more contributor license agreements. See the NOTICE file - distributed with this work for additional information - regarding copyright ownership. The ASF licenses this file - to you under the Apache License, Version 2.0 (the - "License"); you may not use this file except in compliance - with the License. You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - - Unless required by applicable law or agreed to in writing, - software distributed under the License is distributed on an - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - KIND, either express or implied. See the License for the - specific language governing permissions and limitations - under the License. - --> +Thank you for contributing! -<!-- -Thank you for contributing! Please make sure that your code changes -are covered with tests. And in case of new features or big changes -remember to adjust the documentation. +Please provide above a brief description of the changes made in this pull request. +Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ + +Please make sure that your code changes are covered with tests. +And in case of new features or big changes remember to adjust the documentation. -Feel free to ping committers for the review! +Feel free to ping (in general) for the review if you do not see reaction for a few days +(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: -closes: #ISSUE -related: #ISSUE +* closes: #ISSUE +* related: #ISSUE +--> + +## Was generative AI tooling used to co-author this PR? -How to write a good git commit message: -http://chris.beams.io/posts/git-commit/ +<!-- +If generative AI tooling has been used in the process of authoring this PR, please +change below checkbox to `[X]` followed by the name of the tool. --> +- [ ] Yes (please specify the tool below) +Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) Review Comment: Also one more comment here - ASF "policies" and "guidelines" are very well written - they only prescribe what is really a MUST as a MUST, and they leave a lot of freedom to both PMC and contributors to a) follow them b) understand the spirit c) or not. The fact that we are not forcing people to do stuff - but we are telling them what they should do (and make it with just a little friction) - is exactly intentional. Because by the sheer fact of either following them, or not, you are showing if you are good citizen or not. If we see people - clearly submitting AI genearated stuff but not checking the checkbox - that will be an immediate sign of being careful with the PR. Simple signal, but telling a lot. And if we see someone not only checking the box but also uncommenting the generated-by and filling it in it might mean one of the two things: * good citizen user who is good prospect to watch and encourage * very good AI that read the guidelnes and fulfilled them - which makes it likely they also fullfilled other expectations Of course I am simplyfying it a bit, people will attempt to game it as well, but this at least gives us some better signal on the PR quality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
