dabla commented on code in PR #60369:
URL: https://github.com/apache/airflow/pull/60369#discussion_r2705244986
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/operators/powerbi.py:
##########
@@ -65,6 +65,7 @@ class PowerBIDatasetRefreshOperator(BaseOperator):
:param check_interval: Number of seconds to wait before rechecking the
refresh status.
:param request_body: Additional arguments to pass to the request body, as
described in
https://learn.microsoft.com/en-us/rest/api/power-bi/datasets/refresh-dataset-in-group#request-body.
+ :param wait_for_termination: If True, wait for the dataset refresh to
complete. If False, trigger the refresh and return immediately without waiting.
Review Comment:
It's not a limitation or missing implementation, it' just that the hook is
fully async, so you're bound to the trigger mechanism to execute it or you
would need to use asyncio.run but that would be ugly, so it's best to use the
defer mechanism here, but when the operators has to chain 2 operations, then
that means 2 defers, hence why @shreyas-dev introduced the
`wait_for_termination` parameter.
I would definitely **NOT** add the `deferrable` parameter, as all operations
are already deferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
