Miretpl commented on code in PR #61049:
URL: https://github.com/apache/airflow/pull/61049#discussion_r2726019088
##########
helm-tests/tests/helm_tests/other/test_hpa.py:
##########
@@ -106,10 +106,8 @@ def test_hpa_behavior(self, executor):
[
({"celery": {"persistence": {"enabled": True}}}, "StatefulSet"),
({"celery": {"persistence": {"enabled": False}}}, "Deployment"),
- ({"persistence": {"enabled": True}, "celery": {"persistence":
{"enabled": None}}}, "StatefulSet"),
- ({"persistence": {"enabled": False}, "celery": {"persistence":
{"enabled": None}}}, "Deployment"),
Review Comment:
Not meaningful. These tests were testing if the unset behaviour of
`workers.celery` will bring back the previous behaviour of the chart (not
breaking change behaviour), so if we are removing it, they are not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
