Miretpl commented on code in PR #61049:
URL: https://github.com/apache/airflow/pull/61049#discussion_r2726020692
##########
helm-tests/tests/helm_tests/other/test_keda.py:
##########
@@ -179,10 +179,8 @@ def test_keda_query_kubernetes_queue(self, executor,
queue):
[
({"celery": {"persistence": {"enabled": True}}}, "StatefulSet"),
({"celery": {"persistence": {"enabled": False}}}, "Deployment"),
- ({"persistence": {"enabled": True}, "celery": {"persistence":
{"enabled": None}}}, "StatefulSet"),
- ({"persistence": {"enabled": False}, "celery": {"persistence":
{"enabled": None}}}, "Deployment"),
({"persistence": {"enabled": True}}, "StatefulSet"),
- ({"persistence": {"enabled": False}}, "StatefulSet"),
+ ({"persistence": {"enabled": False}}, "Deployment"),
Review Comment:
The test was correct for the previous implementation. As the change of
`workers.persistence.enabled` should not have any effect if
`workers.celery.persistence.enabled` is specified. Now, when we are removing
that behaviour (by making `workers.celery` values null), we expect that change
of `workers.persistence.enabled` will have some effect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
