Miretpl commented on code in PR #61049:
URL: https://github.com/apache/airflow/pull/61049#discussion_r2726022678
##########
helm-tests/tests/helm_tests/airflow_core/test_worker.py:
##########
@@ -33,32 +33,11 @@ class TestWorker:
("CeleryExecutor", {"celery": {"persistence": {"enabled": True}}},
"StatefulSet"),
("CeleryKubernetesExecutor", {"celery": {"persistence":
{"enabled": False}}}, "Deployment"),
("CeleryKubernetesExecutor", {"celery": {"persistence":
{"enabled": True}}}, "StatefulSet"),
- # Test workers.persistence.enabled flag when celery one is default
(expected no impact on kind)
- ("CeleryExecutor", {"persistence": {"enabled": False}},
"StatefulSet"),
+ # Test workers.persistence.enabled flag when celery one is default
+ ("CeleryExecutor", {"persistence": {"enabled": False}},
"Deployment"),
("CeleryExecutor", {"persistence": {"enabled": True}},
"StatefulSet"),
- ("CeleryKubernetesExecutor", {"persistence": {"enabled": False}},
"StatefulSet"),
+ ("CeleryKubernetesExecutor", {"persistence": {"enabled": False}},
"Deployment"),
("CeleryKubernetesExecutor", {"persistence": {"enabled": True}},
"StatefulSet"),
- # Test workers.persistence.enabled flag when celery one is unset
- (
- "CeleryExecutor",
- {"persistence": {"enabled": False}, "celery": {"persistence":
{"enabled": None}}},
- "Deployment",
- ),
- (
- "CeleryExecutor",
- {"persistence": {"enabled": True}, "celery": {"persistence":
{"enabled": None}}},
- "StatefulSet",
- ),
- (
- "CeleryKubernetesExecutor",
- {"persistence": {"enabled": False}, "celery": {"persistence":
{"enabled": None}}},
- "Deployment",
- ),
- (
- "CeleryKubernetesExecutor",
- {"persistence": {"enabled": True}, "celery": {"persistence":
{"enabled": None}}},
- "StatefulSet",
- ),
Review Comment:
Tests were testing if the unset behaviour of `workers.celery` will bring
back the previous behaviour of the chart (not breaking change behaviour), so if
we are removing it, they are not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
