ashb commented on code in PR #61629:
URL: https://github.com/apache/airflow/pull/61629#discussion_r2779141943
##########
providers/standard/src/airflow/providers/standard/operators/python.py:
##########
@@ -637,6 +637,20 @@ def _execute_python_callable_in_subprocess(self,
python_path: Path):
env_vars = dict(os.environ) if self.inherit_env else {}
if fd := os.getenv("__AIRFLOW_SUPERVISOR_FD"):
env_vars["__AIRFLOW_SUPERVISOR_FD"] = fd
+ elif AIRFLOW_V_3_0_PLUS and "__AIRFLOW_SUPERVISOR_FD" not in
env_vars:
Review Comment:
When is this path hit?
##########
providers/standard/src/airflow/providers/standard/utils/python_virtualenv_script.jinja2:
##########
@@ -55,7 +55,10 @@ else:
#}
reinit_supervisor_comms = getattr(task_runner, "reinit_supervisor_comms",
None)
if reinit_supervisor_comms:
- reinit_supervisor_comms()
+ try:
+ reinit_supervisor_comms()
+ except Exception:
+ pass
Review Comment:
No. If expect airflow is true then an error here should fail the task.
Regardless silently ignoring the error is the worst of all paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
