andreahlert commented on code in PR #61629: URL: https://github.com/apache/airflow/pull/61629#discussion_r2779642226
########## providers/standard/src/airflow/providers/standard/utils/python_virtualenv_script.jinja2: ########## @@ -55,7 +55,10 @@ else: #} reinit_supervisor_comms = getattr(task_runner, "reinit_supervisor_comms", None) if reinit_supervisor_comms: - reinit_supervisor_comms() + try: + reinit_supervisor_comms() + except Exception: + pass Review Comment: But I'd keep the try/except itself. reinit failing doesn't mean airflow isn't there, it just means the socket setup broke. If the callable actually needs Variables/Connections it'll fail with a proper error at that point anyway. Crashing the whole task on a socket error before we even get to run user code feels wrong to me. The real fix is the fd propagation in python.py, this is just a fallback. What do ya think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
