AutomationDev85 commented on code in PR #61778:
URL: https://github.com/apache/airflow/pull/61778#discussion_r2822384278
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/triggers/pod.py:
##########
@@ -183,7 +184,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
event = await self._wait_for_container_completion()
yield event
return
- except PodLaunchTimeoutException as e:
+ except (PodLaunchTimeoutException, PodLaunchFailedException) as e:
Review Comment:
I think the triggerer should be the source of truth here: the user defined a
startup timeout, and when it’s reached, Airflow should behave accordingly.
Normally there shouldn’t be a large gap between the triggerer finishing and the
worker starting the operator—except in overload situations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
