AutomationDev85 commented on code in PR #61778:
URL: https://github.com/apache/airflow/pull/61778#discussion_r2832122049
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/triggers/pod.py:
##########
@@ -183,7 +184,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
event = await self._wait_for_container_completion()
yield event
return
- except PodLaunchTimeoutException as e:
+ except (PodLaunchTimeoutException, PodLaunchFailedException) as e:
Review Comment:
I understand your idea behind this but, from my point of view, the triggerer
runs quite stable, which means the current startup timeout is valid. If a user
sees that the pod needs more time to start due to flaky infrastructure, they
can increase startup_timeout. I don’t think it makes sense to keep the pod
running just because it might recover later. If you want that behavior, I
suggest creating a new PR that adds an option to disable startup_timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
