johnhoran commented on code in PR #61778:
URL: https://github.com/apache/airflow/pull/61778#discussion_r2823146005
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/triggers/pod.py:
##########
@@ -183,7 +184,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
event = await self._wait_for_container_completion()
yield event
return
- except PodLaunchTimeoutException as e:
+ except (PodLaunchTimeoutException, PodLaunchFailedException) as e:
Review Comment:
The startup_timeout itself is a fairly loose amount of time, it doesn't
account for the time taken for the triggerer to adopt the task, and it doesn't
account for triggerer restarts. I think its just for situations where you want
an early notification if the pod doesn't start, and not have to wait for a task
timeout (or indefinitely if it isn't set). 2-3 minutes in the kubernetes
executor could be enough time for some tasks to complete. I don't understand
why killing a running pod would be preferable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
