jedcunningham commented on code in PR #62361:
URL: https://github.com/apache/airflow/pull/62361#discussion_r2842468986
##########
airflow-core/src/airflow/api_fastapi/auth/managers/base_auth_manager.py:
##########
@@ -798,15 +798,6 @@ def get_extra_menu_items(self, *, user: T) ->
list[ExtraMenuItem]:
"""
return []
- @staticmethod
- def get_db_manager() -> str | None:
Review Comment:
Same here, breaking change and we can't remove it until Airflow 4.
##########
providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py:
##########
@@ -654,10 +654,6 @@ def get_extra_menu_items(self, *, user: User) ->
list[ExtraMenuItem]:
if self._is_authorized(method="MENU",
resource_type=item["resource_type"], user=user)
]
- @staticmethod
- def get_db_manager() -> str | None:
Review Comment:
This feels like a breaking change. We can't remove this until we no longer
support 3.1, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
