jedcunningham commented on code in PR #62361:
URL: https://github.com/apache/airflow/pull/62361#discussion_r2843719273


##########
airflow-core/src/airflow/api_fastapi/auth/managers/base_auth_manager.py:
##########
@@ -798,15 +798,6 @@ def get_extra_menu_items(self, *, user: T) -> 
list[ExtraMenuItem]:
         """
         return []
 
-    @staticmethod
-    def get_db_manager() -> str | None:

Review Comment:
   I mena less this actual method, and more Airflow not finding and registering 
the db managers that may exist in auth managers, is a breaking change.



##########
airflow-core/src/airflow/api_fastapi/auth/managers/base_auth_manager.py:
##########
@@ -798,15 +798,6 @@ def get_extra_menu_items(self, *, user: T) -> 
list[ExtraMenuItem]:
         """
         return []
 
-    @staticmethod
-    def get_db_manager() -> str | None:

Review Comment:
   I mean less this actual method, and more Airflow not finding and registering 
the db managers that may exist in auth managers, is a breaking change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to