dheerajturaga commented on code in PR #62361:
URL: https://github.com/apache/airflow/pull/62361#discussion_r2843738468
##########
airflow-core/src/airflow/api_fastapi/auth/managers/base_auth_manager.py:
##########
@@ -798,15 +798,6 @@ def get_extra_menu_items(self, *, user: T) ->
list[ExtraMenuItem]:
"""
return []
- @staticmethod
- def get_db_manager() -> str | None:
Review Comment:
Oh yes, I agree! If someone has a custom auth manager and are using their
own db manager, removing this support will break their usecase. I think we
should just edit Fab and base auth manager but leave support for this untouched
for 3rd party auth managers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
