potiuk commented on PR #63467: URL: https://github.com/apache/airflow/pull/63467#issuecomment-4065593164
@antonio-mello-ai This PR has a few issues that need to be addressed before it can be reviewed — please see our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria). **Issues found:** - :x: **Missing tests**: The PR introduces new interactive UI behaviour — a LogSearchInput component, search state management, keyboard navigation (/,Enter,Shift+Enter,Escape), match computation, and scroll-to-match logic — but no new test files appear among the changed files. The passing 'React UI tests' check covers the existing suite only; there are no new unit or integration tests that exercise the search feature (e.g. match-index computation, wrap-around navigation, highlight logic in getHighlightColor). The code review checklist requires tests for every new public method or behaviour, covering success, failure, and edge cases. - :warning: **Description does not match code**: The PR description's 'Files changed' table explicitly states 'Logs.tsx | Search state, match computation via `useMemo`, callbacks'. However, the actual diff shows getSearchMatchIndices() is a plain function called as `const searchMatchIndices = getSearchMatchIndices();` on every render — there is no useMemo wrapping it. For large log outputs this will re-parse and re-scan all log lines on every keystroke and every unrelated state update, which is a real performance concern. The description describes something different from what the code actually does, which is flagged as an AI-generated code signal. > **Note:** Your branch is **24 commits behind `main`**. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results. **What to do next:** - The comment informs you what you need to do. - Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed. - There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. - Maintainers will then proceed with a normal review. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
