antonio-mello-ai commented on PR #63467: URL: https://github.com/apache/airflow/pull/63467#issuecomment-4067095543
Rebased on latest `main` and addressed all feedback: **Tests added (24 new tests across 3 files):** - `utils.test.ts` — 8 unit tests for `getHighlightColor` (current match, other matches, URL hash, edge cases) - `LogSearchInput.test.tsx` — 10 component tests (keyboard navigation: `/`, `Enter`, `Shift+Enter`, `Escape`, button states, disabled when zero matches) - `Logs.test.tsx` — 6 integration tests (search + match computation + navigation flow) **Refactoring for testability:** - Extracted `getHighlightColor` from `TaskLogContent.tsx` to `utils.ts` — pure function, testable without DOM **PR description updated:** - Removed `useMemo` references — the Airflow UI has `babel-plugin-react-compiler` enabled (`vite.config.ts`), which handles memoization automatically at build time. This is why `useMemo`/`useCallback` were removed per @bbovenzi's review. All 170 tests passing, lint clean, pre-commit hooks pass. Still awaiting @bbovenzi's direction on the streaming logs concern from the earlier review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
