pierrejeambrun commented on PR #64333: URL: https://github.com/apache/airflow/pull/64333#issuecomment-4145359191
This is different from retries. This is for auto-refresh only. We do have a retry strategy implemented. 4xx beside 429 won't be retried. https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/ui/src/queryClient.ts#L34 Could be worth indeed following the same pattern for deactivating auto-refresh. 4xx beside 429 = disable auto refresh. But I removed that at first because I was scared this could cause side effects, for instance token expires, we get a 403, then we blacklist that endpoint for 'auto refresh' while we get redirected to the auth page and re-login, then that endpoint won't ever auto-refresh again wrongly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
