jscheffl commented on code in PR #64062:
URL: https://github.com/apache/airflow/pull/64062#discussion_r3006159130


##########
airflow-core/src/airflow/models/variable.py:
##########
@@ -480,14 +482,14 @@ def check_for_write_conflict(key: str) -> None:
                             _backend_name,
                             _backend_name,
                         )
-                        return
+                        warning_logged = True
                 except Exception:
                     log.exception(

Review Comment:
   I am wondernig a bit why we log an exception here, because it is actually 
positive that we did not see a conflict. Does somebody know why we log an 
exception here? A debug smells like more appropriate??



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to