Kundan-CR7 commented on code in PR #64062:
URL: https://github.com/apache/airflow/pull/64062#discussion_r3006176450
##########
airflow-core/src/airflow/models/variable.py:
##########
@@ -480,14 +482,14 @@ def check_for_write_conflict(key: str) -> None:
_backend_name,
_backend_name,
)
- return
Review Comment:
@jscheffl I had previously tried keeping the early return, but I ran into
failing tests, which led me to explore iterating through all backends.
Could you please advise on the expected behavior here — should we prioritize
simplicity with early return, or ensure all backends are checked to satisfy the
current tests? I’d be happy to align the implementation accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
