jscheffl commented on code in PR #64062:
URL: https://github.com/apache/airflow/pull/64062#discussion_r3006157877
##########
airflow-core/src/airflow/models/variable.py:
##########
@@ -480,14 +482,14 @@ def check_for_write_conflict(key: str) -> None:
_backend_name,
_backend_name,
)
- return
Review Comment:
The only reason this function has is to print the warning, if it is printed,
why would it make sense looping further around the other secret stores and then
checking but skipping to print a warning?
Previous code was directly exiting, which in my view is sufficient and easy
enough, no need to have a variable holding the status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
