xchwan commented on PR #67146: URL: https://github.com/apache/airflow/pull/67146#issuecomment-4494027495
I think the simplest fix is to strip the year check out of ```check_notice_files.py``` and keep only the ASF declaration check. The scheduled notification approach still requires someone to manually run ```update_notice_year.py``` at the end anyway. And if the update is done in late December, Copyright 2016-2027 would be incorrect while still in 2026, which ```check_notice_files.py``` would then reject — update early and the year is wrong, wait until 01/01 and everyone is at a New Year's party. So: - pre-commit only blocks genuine errors where the ASF declaration is missing entirely - PRs never fail due to year drift - Someone can run update_notice_year.py when they remember, and nothing explodes if they don't -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
