Codingaditya17 opened a new pull request, #67674:
URL: https://github.com/apache/airflow/pull/67674
Closes #67647
## What changed
This PR removes the fragile conditional dialog mount pattern from the
affected Clear and Mark-as flows so `@chakra-ui/react` can be safely unpinned
from `~3.34.0` and upgraded to `^3.35.0`.
The issue happened because Ark UI 5.36+ changed how modal pointer-event
cleanup is handled during dialog close transitions. When our dialogs were
conditionally rendered with patterns like `{open ? <Dialog /> : undefined}`,
the dialog could unmount before the close transition completed, leaving the
page stuck with `pointer-events: none`.
## Implementation
- Always render the affected Clear / Mark-as dialogs and control visibility
through the `open` prop.
- Removed conditional dialog mounting from:
- `ClearRunButton`
- `ClearTaskInstanceButton`
- `MarkRunAsButton`
- `MarkTaskInstanceAsButton`
- `TaskInstance/Header`
- Reset local note state from the latest DagRun / TaskInstance note when the
dialog opens or closes.
- Preserved the behavior fixed by #47071 so reopened dialogs show the latest
note instead of stale typed state.
- Gated the Clear Run dry-run query with `enabled: open` to avoid
unnecessary requests while the dialog is closed.
- Bumped `@chakra-ui/react` from `~3.34.0` to `^3.35.0`.
- Updated `pnpm-lock.yaml`.
- Removed the Chakra dependency caveat from UI `CONTRIBUTING.md`.
## Testing
```bash
ulimit -n 4096 && uv run prek run ts-compile-lint-ui --all-files
Result: passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
