SyedIshmumAhnaf commented on PR #67674:
URL: https://github.com/apache/airflow/pull/67674#issuecomment-4575356872
Thanks for taking this on. I reviewed this against the #47071 note-state
regression mentioned in #67647.
One possible missed path: `MarkTaskInstanceAsButton` now always renders
`MarkTaskInstanceAsDialog`, but `MarkTaskInstanceAsDialog` still initializes
local `note` state from `taskInstance.note` and does not appear to reset it on
open/close/prop change. Since the dialog now remains mounted across closes,
this looks like it could preserve a stale note after the backing
`taskInstance.note` changes and the dialog is reopened.
The other note-bearing dialogs seem to add an open/reset path, so I think
`MarkTaskInstanceAsDialog` may need the same treatment.
Also worth checking: the modified dialogs pass zero-arg close handlers
directly to `Dialog.Root onOpenChange`; existing typed usage appears to expect
`{ open: boolean }`, so guarding on `details.open === false` may be safer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
