SyedIshmumAhnaf commented on PR #67674:
URL: https://github.com/apache/airflow/pull/67674#issuecomment-4582450128
Thanks for the update. I rechecked the note-state path I mentioned earlier,
and `MarkTaskInstanceAsDialog` now has the same open/close reset treatment as
the other note-bearing dialogs, so the #47071 stale-note concern looks
addressed to me.
I don’t see any further blocker from my earlier review. The only remaining
minor thing I’d defer to maintainers on is whether they prefer guarding
`onOpenChange` with `details.open === false`, since the current handlers still
ignore the `{ open }` details object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
