bbovenzi commented on code in PR #67725:
URL: https://github.com/apache/airflow/pull/67725#discussion_r3382884190
##########
airflow-core/src/airflow/ui/src/components/AssetExpression/types.ts:
##########
@@ -16,31 +16,25 @@
* specific language governing permissions and limitations
* under the License.
*/
+import type {
+ AssetExpressionAlias,
+ AssetExpressionAll,
+ AssetExpressionAny,
+ AssetExpressionAsset,
+ AssetExpressionRef,
+} from "openapi/requests/types.gen";
-type Asset = {
- asset: {
- group: string;
- id: number;
- name: string;
- uri: string;
- };
-};
+// `asset_expression` is now typed on the API side (see the AssetExpression*
models in the Python
+// `datamodels/common.py`), so these aliases are derived from the generated
client instead of being
+// hand-maintained here. The previous local union could drift from the server
shape with no runtime check.
Review Comment:
We don't need this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
