Anuragp22 commented on PR #67725:
URL: https://github.com/apache/airflow/pull/67725#issuecomment-4692443780
Ready for maintainer review.
Two commits since the last look:
* Fixed the `ruff-format` failure on `partitioned_dag_runs.py`, the only red
check.
* Hardened the newly-typed `asset_expression` field against pre-3.0 migrated
rows. The 2.x dataset scheduler stored shapes the 3.0 column rename carried
over verbatim: a bare URI string, `{"any": [<strings>]}`, `{"alias":
"<name>"}`. The typed field would return a 500 on those until the DAG is
re-parsed. `MaybeAssetExpression` now coerces any unrecognized stored shape to
`null`, reproducing the blank render the UI showed while the field was an
untyped dict. Added round-trip and coercion tests.
I've addressed all three of `bbovenzi`'s comments on
`AssetExpression/types.ts`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
