Anuragp22 commented on PR #67725:
URL: https://github.com/apache/airflow/pull/67725#issuecomment-4666136928
Merged main, which now includes AIP-76 (#64571). AIP-76 rewrote the same
`asset_expression` code, so resolving the overlap grew the diff.
What changed since the last review:
* Extended the typing to the partitioned-dag-run responses AIP-76 added
(`PartitionedDagRunCollectionResponse`, `PartitionedDagRunDetailResponse`),
alongside the original `DAGDetailsResponse`, `DAGWithLatestDagRunsResponse`,
and `NextRunAssetsResponse`.
* AIP-76 builds the `next_run_assets` and partitioned responses from a dict
via explicit constructors. Since `asset_expression` is now typed, those routes
use `model_validate({...})` so pydantic validates the stored dict into the
model. This mirrors `DAGDetailsResponse.model_validate(dag_model)` in
`routes/public/dags.py` and leaves AIP-76's partition logic unchanged.
* Addressed the earlier review: `ExpressionType` is now derived from the
generated client, `AssetSummary` is removed, and the `as ExpressionType` casts
in `AssetProgressCell.tsx` and `AssetSchedule.tsx` are gone. Also removed the
now-unused `NextRunEvent` type.
* Regenerated the OpenAPI spec and TypeScript client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
