kaxil commented on code in PR #68390:
URL: https://github.com/apache/airflow/pull/68390#discussion_r3396911974
##########
airflow-core/src/airflow/api_fastapi/execution_api/datamodels/taskinstance.py:
##########
@@ -286,6 +286,11 @@ class TaskInstance(BaseModel):
map_index: int = -1
hostname: str | None = None
context_carrier: dict | None = None
+ # Defaults keep hand-built instances (tests, dry runs) valid; the executor
+ # workload always sends the real values.
+ queue: str = "default"
+ pool_slots: int = 1
+ priority_weight: int = 1
Review Comment:
Right that the DTO type itself is unreleased -- the compat concern is on the
other side: released edge workers deserialize `edge_job.command` with the
`workloads.TaskInstance` of the core installed on the worker, where these
fields are required (since 3.0). And with
`minimum_acceptable_core_version_for_workers` (#66292, released in edge3
3.6.0), a worker on an older core talking to a 3.3 server is a supported setup
-- dropping the fields from the serialized workload would fail validation on
those workers. That's the only reason they stay on the wire; they're out of the
worker-facing schema either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
