kaxil commented on code in PR #68390:
URL: https://github.com/apache/airflow/pull/68390#discussion_r3397396720
##########
task-sdk/src/airflow/sdk/execution_time/schema/versions/__init__.py:
##########
@@ -21,5 +21,8 @@
bundle = VersionBundle(
HeadVersion(),
+ # The initial, not-yet-released version of the contract. Shape changes to
+ # registered models land directly in the head snapshot until this ships;
+ # no VersionChange entries are possible against the bundle floor.
Review Comment:
Removed. Heads-up: `check-supervisor-schemas-versions` will now flag this PR
(the snapshot changed with nothing touched under `versions/`), and there's no
`VersionChange` to write against the unreleased floor version -- open to
suggestions on how the hook should treat that case.
##########
task-sdk/src/airflow/sdk/api/datamodels/_generated.py:
##########
@@ -560,6 +560,7 @@ class TaskInstance(BaseModel):
map_index: Annotated[int | None, Field(title="Map Index")] = -1
hostname: Annotated[str | None, Field(title="Hostname")] = None
context_carrier: Annotated[dict[str, Any] | None, Field(title="Context
Carrier")] = None
+ queue: Annotated[str | None, Field(title="Queue")] = "default"
Review Comment:
Generator artifact: datamodel-code-generator emits `X | None` for every
non-required field regardless of schema nullability -- same as `map_index: int
| None = -1` just above. The server-side model is a non-nullable `str` with a
default; making the generated type strictly `str` would mean making the field
required (no default) in the schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
