Lee-W commented on code in PR #66854:
URL: https://github.com/apache/airflow/pull/66854#discussion_r3402188077
##########
scripts/ci/prek/check_connection_doc_labels.py:
##########
@@ -39,6 +39,7 @@
import re
import sys
+from os import walk
Review Comment:
why do we need to make change to this file
##########
scripts/ci/prek/check_partition_mapper_defaults_in_sync.py:
##########
@@ -74,22 +74,25 @@ def _find_attr_value(file_path: Path) -> ast.Dict:
continue
for stmt in node.body:
target_name = None
+ value: ast.expr | None = None
Review Comment:
I think this pr has nothing to do with partition. we shouldn't touch this
file
##########
airflow-core/src/airflow/config_templates/airflow_local_settings.py:
##########
@@ -174,34 +174,40 @@ def _default_conn_name_from(mod_path, hook_name):
from airflow.providers.amazon.aws.log.s3_task_handler import
S3RemoteLogIO
_default_conn_name_from("airflow.providers.amazon.aws.hooks.s3",
"S3Hook")
- REMOTE_TASK_LOG = S3RemoteLogIO(
- **cast(
- "dict[str, Any]",
- {
- "base_log_folder": BASE_LOG_FOLDER,
- "remote_base": remote_base_log_folder,
- "delete_local_copy": delete_local_copy,
- }
- | _io_kwargs,
- )
+ REMOTE_TASK_LOG = cast(
Review Comment:
Why do we need to changet this here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
