hkc-8010 commented on code in PR #66854:
URL: https://github.com/apache/airflow/pull/66854#discussion_r3402826374
##########
airflow-core/src/airflow/config_templates/airflow_local_settings.py:
##########
@@ -174,34 +174,40 @@ def _default_conn_name_from(mod_path, hook_name):
from airflow.providers.amazon.aws.log.s3_task_handler import
S3RemoteLogIO
_default_conn_name_from("airflow.providers.amazon.aws.hooks.s3",
"S3Hook")
- REMOTE_TASK_LOG = S3RemoteLogIO(
- **cast(
- "dict[str, Any]",
- {
- "base_log_folder": BASE_LOG_FOLDER,
- "remote_base": remote_base_log_folder,
- "delete_local_copy": delete_local_copy,
- }
- | _io_kwargs,
- )
+ REMOTE_TASK_LOG = cast(
Review Comment:
Thanks, good point. This file is not part of the asset lock-contention fix;
it was added only because after the rebase the full `airflow-core` mypy check
failed without these casts.
I tried removing the unrelated files locally. The PR diff becomes much
cleaner, but `prek run --files ...` then fails in full `airflow-core` mypy with
7 `REMOTE_TASK_LOG` assignment errors in this file. Focused asset tests still
pass (`218 passed, 1 skipped`), so this is a scope-vs-CI tradeoff rather than a
behavior dependency.
Would you still prefer that I remove this file from the PR and accept/follow
up on the mypy CI failure separately, or should I keep this minimal mypy-only
change here so CI stays green?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
