hkc-8010 commented on code in PR #66854:
URL: https://github.com/apache/airflow/pull/66854#discussion_r3404116794
##########
airflow-core/src/airflow/config_templates/airflow_local_settings.py:
##########
@@ -174,34 +174,40 @@ def _default_conn_name_from(mod_path, hook_name):
from airflow.providers.amazon.aws.log.s3_task_handler import
S3RemoteLogIO
_default_conn_name_from("airflow.providers.amazon.aws.hooks.s3",
"S3Hook")
- REMOTE_TASK_LOG = S3RemoteLogIO(
- **cast(
- "dict[str, Any]",
- {
- "base_log_folder": BASE_LOG_FOLDER,
- "remote_base": remote_base_log_folder,
- "delete_local_copy": delete_local_copy,
- }
- | _io_kwargs,
- )
+ REMOTE_TASK_LOG = cast(
Review Comment:
Follow-up after the cleanup push: I removed the unrelated CI script changes
and related script test from the PR, but kept this `airflow_local_settings.py`
cast-only change because removing it makes the full `airflow-core` mypy check
fail. The refreshed PR now has 69 passing checks, 0 failing, 0 pending, and
this is the only remaining unrelated-looking file in the diff for that mypy
reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
