YeonShin commented on code in PR #67595:
URL: https://github.com/apache/airflow/pull/67595#discussion_r3426339328
##########
airflow-core/src/airflow/ui/src/pages/Dag/Calendar/calendarUtils.test.ts:
##########
@@ -153,6 +154,39 @@ describe("createCalendarScale", () => {
});
});
Review Comment:
Thanks for catching this! I’ve added new test cases that distribute runs
across different dates (`2026-04-08` and `2026-04-09`) to ensure the dynamic
gradient threshold and intensity calculation branches are fully exercised and
verified.
##########
airflow-core/src/airflow/ui/src/pages/Dag/Calendar/calendarUtils.test.ts:
##########
@@ -153,6 +154,39 @@ describe("createCalendarScale", () => {
});
});
+ it("returns the failed color for a failed-only cell in total mode", () => {
Review Comment:
Fully agreed. I’ve added a dedicated test case for this specific branch
(`prioritizes failed over running over success when multiple actual states
coexist with pending`). It now explicitly asserts that the highest priority
actual state claims the `primary` slot alongside the pending state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
