YeonShin commented on code in PR #67595:
URL: https://github.com/apache/airflow/pull/67595#discussion_r3426341143
##########
airflow-core/src/airflow/ui/src/pages/Dag/Calendar/calendarUtils.ts:
##########
@@ -291,24 +330,39 @@ export const createCalendarScale = (
actual: string | { _dark: string; _light: string };
planned: string | { _dark: string; _light: string };
} => {
- const actualCount = getActualRunCount(counts, viewMode);
+ const failedCount = counts.failed;
+ const runningCount = viewMode === "total" ? counts.running : 0;
+ const successCount = viewMode === "total" ? counts.success : 0;
+
const hasPending = getPendingRunCount(counts) > 0;
- const hasActual = actualCount > 0;
+ const hasActual = failedCount > 0 || runningCount > 0 || successCount > 0;
- if (hasPending && hasActual) {
- let actualColor = colorScheme[0] ?? EMPTY_COLOR;
+ type ColorValue = string | { _dark: string; _light: string };
+ const getIntensityColor = (count: number, scheme: Array<ColorValue>) => {
Review Comment:
Thanks for the guidance! I understood that the bottom legend lacked
indicators for the actual run states (Success, Running, Failed) since it only
originally showed Planned and Mixed. To fix this, I extracted a reusable
`<LegendIcon/>` and expanded the bottom legend to explicitly map out Success
(green), Running (cyan), Failed (red), and Planned (gray) samples. This ensures
any status color or mixed blend on the grid can be instantly decoded by the
user.
<img width="2002" height="1181" alt="image"
src="https://github.com/user-attachments/assets/a6896bae-8df4-457b-9843-a0b896b96645";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
