YeonShin commented on PR #67595: URL: https://github.com/apache/airflow/pull/67595#issuecomment-4727312393
> Thanks for picking this up — the priority-based rendering is a clear improvement over what's on main, and the screenshots make the case well. > > A few things to address before merge Thanks for the solid review! I’ve addressed all your feedback and pushed the updates after rebasing on top of the latest upstream/main. Here’s a quick wrap-up of what’s been done: 1. **Helper Extraction:** Moved the overlapping state-priority rules into a single `resolveCellColor` helper to clean up both color paths. 2. **Clearer Naming:** Renamed the ambiguous `actual`/`planned` keys to `primary` and `secondary` so it’s strictly about visual mapping. 3. **Legend Remodel:** Instead of leaving it as a follow-up, I updated the `CalendarLegend` using the new dynamic `<LegendIcon />`. It now explicitly shows Success, Running, Failed, and Planned samples. 4. **Added Tests:** Added the requested tests for gradient date spans and multi-state pending branches. I also proactively threw in a defensive test case like handling empty scales (`[]`) just to be safe. 5. **Priority Alignment:** I also took the extra step to align actual-vs-actual color blending so that the most critical status consistently claims the `primary` (top-right) position (`failed` > `running` > `success`) for better visual clarity. Everything runs clean and all tests are passing green locally. Let me know if this looks good to you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
