jason810496 commented on code in PR #66610: URL: https://github.com/apache/airflow/pull/66610#discussion_r3449916381
########## airflow-core/src/airflow/utils/log/callback_log_reader.py: ########## @@ -0,0 +1,182 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Reader for callback execution logs stored in remote or local storage.""" + +from __future__ import annotations + +import logging +import os +from collections.abc import Generator +from contextlib import suppress +from pathlib import Path +from typing import TYPE_CHECKING + +from airflow.configuration import conf +from airflow.utils.log.file_task_handler import ( + StructuredLogMessage, + _interleave_logs, + _stream_lines_by_chunk, +) + +if TYPE_CHECKING: + from airflow._shared.logging.remote import LogSourceInfo, RawLogStream + +logger = logging.getLogger(__name__) + + +def _get_callback_log_relative_paths(dag_id: str, run_id: str, callback_id: str) -> list[str]: + """ + Construct the relative log paths for a callback execution. + + Returns paths for both executor callbacks (sync) and triggerer callbacks (async). + The executor path matches the format used in ExecuteCallback.make(): + executor_callbacks/{dag_id}/{run_id}/{callback_id} + The triggerer path matches what TriggerLoggingFactory writes for callback triggers: + triggerer_callbacks/{dag_id}/{run_id}/{callback_id} + """ + return [ + f"executor_callbacks/{dag_id}/{run_id}/{callback_id}", + f"triggerer_callbacks/{dag_id}/{run_id}/{callback_id}", + ] + + +def read_callback_log( + dag_id: str, + run_id: str, + callback_id: str, +) -> Generator[StructuredLogMessage, None, None]: + """ + Read callback logs from remote and/or local storage. + + Tries both executor_callbacks and triggerer_callbacks paths. + For each path, tries remote storage first (if configured), then falls back to local filesystem. + Returns a generator of StructuredLogMessage objects suitable for the API response. + + :param dag_id: The Dag ID associated with the callback. + :param run_id: The Dag run ID associated with the callback. + :param callback_id: The unique callback identifier. + :return: Generator of StructuredLogMessage objects. + """ + relative_paths = _get_callback_log_relative_paths(dag_id, run_id, callback_id) + + sources: LogSourceInfo = [] + remote_logs: list[RawLogStream] = [] + local_logs: list[RawLogStream] = [] + + for relative_path in relative_paths: + # Try remote storage first + with suppress(Exception): + remote_sources, remote_log_streams = _read_callback_remote_logs(relative_path) + if remote_log_streams: + sources.extend(remote_sources) + remote_logs.extend(remote_log_streams) + + # Try local filesystem + if not remote_logs: + local_sources, local_log_streams = _read_callback_local_logs(relative_path) + if local_log_streams: + sources.extend(local_sources) + local_logs.extend(local_log_streams) + + # If we found logs at this path, no need to check the next path + if remote_logs or local_logs: + break + + if not remote_logs and not local_logs: + yield StructuredLogMessage(event="No callback logs found.", timestamp=None) + return + + # Emit source information header + yield StructuredLogMessage(event="::group::Log message source details", sources=sources) # type: ignore[call-arg] + yield StructuredLogMessage(event="::endgroup::") + + # Interleave and yield all log streams + log_stream = _interleave_logs(*remote_logs, *local_logs) + yield from log_stream + + +def _read_callback_remote_logs( Review Comment: Additionally, all the `_read_...*` functions are mostly duplicated from the existing `airflow-core/src/airflow/utils/log/log_reader.py`. It's fine to keep this as-is, but it would be nice to introduce common functions between two log reading path as follow-up. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
