seanghaeli commented on code in PR #66610:
URL: https://github.com/apache/airflow/pull/66610#discussion_r3450035073
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -428,8 +428,35 @@ def upload_to_remote(self):
# Never actually called, nothing to do
return
+ if self.ti is None:
+ # Callback triggers have no task instance — upload using the path
directly.
+ self._upload_callback_log_to_remote()
+ return
+
upload_to_remote(self.bound_logger, self.ti)
+ def _upload_callback_log_to_remote(self):
+ """Upload callback trigger logs to remote storage without a task
instance."""
+ from airflow.sdk.log import load_remote_log_handler,
relative_path_from_logger
Review Comment:
It's a good callout, agreed it's a near duplicate. Since this is related to
code cleanup and it touches the triggerer upload path, I'd rather not rework
that path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
