pierrejeambrun commented on code in PR #66610:
URL: https://github.com/apache/airflow/pull/66610#discussion_r3461044748
##########
airflow-core/src/airflow/ui/src/pages/Run/DeadlineStatus.tsx:
##########
@@ -160,42 +153,28 @@ export const DeadlineStatus = ({ dagId, dagRunId, endDate
}: DeadlineStatusProps
);
}
- // Single deadline — show inline with Expected / Actual dates and precise
duration.
+ // Single deadline — show inline with Expected / Actual times.
const [dl] = deadlines;
Review Comment:
can't an entity have multiple missed dealines?
I don't think the way we display this information should have 3 branches
based on items count. It's making things confusing.
But that's not related to this PR, can be a follow up.
Can you add screenshot for the log button when there are multiple
callbacks/deadlines to show.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
