ferruzzi commented on code in PR #69046:
URL: https://github.com/apache/airflow/pull/69046#discussion_r3484642607
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py:
##########
@@ -615,16 +629,24 @@ def delete_pod(self, pod_name: str, namespace: str) ->
None:
"""Delete Pod from a namespace; does not raise if it does not exist."""
try:
self.log.info("Deleting pod %s in namespace %s", pod_name,
namespace)
- with Stats.timer("kubernetes_executor.pod_deletion"):
+ with Stats.timer(
+ "kubernetes_executor.pod_deletion",
tags=prune_dict({"team_name": self.team_name})
Review Comment:
For these timers, can you run a manual test and confirm they work as
intended? Technically this is a change; even if team_name is `None`, this
will now be called with `tags={}` where previously it didn't get a `tags` at
all. You may need to do something like `tags=prune_dict(...) or None`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
