justinpakzad commented on code in PR #69046:
URL: https://github.com/apache/airflow/pull/69046#discussion_r3485003421
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py:
##########
@@ -615,16 +629,24 @@ def delete_pod(self, pod_name: str, namespace: str) ->
None:
"""Delete Pod from a namespace; does not raise if it does not exist."""
try:
self.log.info("Deleting pod %s in namespace %s", pod_name,
namespace)
- with Stats.timer("kubernetes_executor.pod_deletion"):
+ with Stats.timer(
+ "kubernetes_executor.pod_deletion",
tags=prune_dict({"team_name": self.team_name})
Review Comment:
Just chiming in here as I was doing some testing for amazon and I think we
should be covered based on what I found here in the `stats.py` file:
https://github.com/apache/airflow/blob/438107f03ef27de66f0f3c1fb2e2fd7d6edfec0d/shared/observability/src/airflow_shared/observability/metrics/stats.py#L269-L271
Still worth running some manual tests but figured I'd share that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
