SameerMesiah97 commented on code in PR #69046:
URL: https://github.com/apache/airflow/pull/69046#discussion_r3486194216
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py:
##########
@@ -615,16 +629,24 @@ def delete_pod(self, pod_name: str, namespace: str) ->
None:
"""Delete Pod from a namespace; does not raise if it does not exist."""
try:
self.log.info("Deleting pod %s in namespace %s", pod_name,
namespace)
- with Stats.timer("kubernetes_executor.pod_deletion"):
+ with Stats.timer(
+ "kubernetes_executor.pod_deletion",
tags=prune_dict({"team_name": self.team_name})
Review Comment:
@ferruzzi
Do you still want me to run a manual test with a StatsD backend? By tracing
the codepath, we can deduce that no tag will be passed if the `team_name` is
`None` (there is a falsy check in the `timer` function in the stats.py module
as @justinpakzad pointed out). So this means there is no behavior change for
the default case i.e. no team present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
