henry3260 commented on code in PR #69121:
URL: https://github.com/apache/airflow/pull/69121#discussion_r3552376841
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/grid.py:
##########
@@ -291,8 +291,9 @@ def get_grid_runs(
.correlate(DagRun)
.label("has_missed_deadline")
)
+ has_note_subq = exists().where(DagRunNote.dag_run_id ==
DagRun.id).correlate(DagRun).label("has_note")
Review Comment:
> You are right, I've added `DagRunNote.content.isnot(None)` to the
`has_note_subq`.
Could we apply the same `content.isnot(None)` guard for `TaskInstanceNote`
as well, to keep the `has_note` logic consistent across dag runs and task
instances?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
