pierrejeambrun commented on code in PR #69121:
URL: https://github.com/apache/airflow/pull/69121#discussion_r3552499675


##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/grid.py:
##########
@@ -291,8 +291,14 @@ def get_grid_runs(
         .correlate(DagRun)
         .label("has_missed_deadline")
     )
+    has_note_subq = (
+        exists()
+        .where(DagRunNote.dag_run_id == DagRun.id, 
DagRunNote.content.isnot(None))

Review Comment:
   ```suggestion
           .where(DagRunNote.dag_run_id == DagRun.id)
   ```
   
   This piece wasn't here on the TI counterpart. Either remove both, or add 
both. It needs to remain consistent.
   
   (Is a row note with 'empty' content considered as having a note or not)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to