nailo2c commented on code in PR #69121:
URL: https://github.com/apache/airflow/pull/69121#discussion_r3534320329
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/grid.py:
##########
@@ -291,8 +291,9 @@ def get_grid_runs(
.correlate(DagRun)
.label("has_missed_deadline")
)
+ has_note_subq = exists().where(DagRunNote.dag_run_id ==
DagRun.id).correlate(DagRun).label("has_note")
Review Comment:
Hi, could we also check `DagRunNote.content` here? If an existing note is
patched with `{"note": NULL}`, the DB can still have a `DagRunNote.content` row
with `content=NULL`.
This `exists()` check would still return `has_note=True`, so the UI may show
a note marker for an empty note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
