Andrushika commented on PR #69965: URL: https://github.com/apache/airflow/pull/69965#issuecomment-5069356289
@jason810496 A small question to clarify: since we are going to validate the IDs in build time, I am planning to implement it in `runPack()` (the function behind the `go tool airflow-go-pack`). Since you mentioned we should keep the validation best-effort, I want to confirm how strict the pack step should be. The `..` case depends on [core] `allow_double_dot_in_ids` and can be customed by users on the server side, so the client can only warn. But the length and charset rules are rejected by the server unconditionally, so failing early seems possible for them. I have two options and would like to ask your opinion: - Reject the pack when the `id` is invalid, except the `..` case, which only gives a warning - Still allow the pack even if some `id` is invalid, give warnings in all the invalid cases Which one do you prefer? Thanks! I would prefer to keep all of them as warnings and still allow building, because it can prevent drifting that TP mentioned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
