Andrushika commented on PR #69965: URL: https://github.com/apache/airflow/pull/69965#issuecomment-5073171507
All tests passed, ready for review! > The reason is that the following snippet will validate the task runtime in server side and be served as source of truth for validation. > > https://github.com/apache/airflow/blob/ffde96203e76c0c27ccf1ae6eeaad270653248bf/airflow-core/src/airflow/serialization/definitions/dag.py#L637-L648 > > For the `a..b` case, we can just raise the warning (since we can't trust the env / config at client side). Please let me know if there's other direction that makes more sense to you. A little fact I found: On the current `main`, only `run_id` checks the `a..b` case. Core and task-sdk do not validate `dag_id` and `task_id` in the case of double dots. I guess we should also handle this in the core? If it is, I would be happy to open a follow-up PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
