mitre88 commented on code in PR #70488:
URL: https://github.com/apache/airflow/pull/70488#discussion_r3654663675
##########
providers/google/src/airflow/providers/google/cloud/operators/gcs.py:
##########
@@ -229,18 +229,18 @@ def __init__(
super().__init__(**kwargs)
self.bucket = bucket
self.prefix = prefix
- if delimiter:
- warnings.warn(
- "Usage of 'delimiter' is deprecated, please use 'match_glob'
instead. Planned removal date: October 5, 2026.",
- AirflowProviderDeprecationWarning,
- stacklevel=2,
- )
Review Comment:
Agreed — the deprecation applies to any usage of the argument, not the
rendered value. Moved the warning back to `__init__` as it is on main, restored
the `GCSListObjectsOperator` exemption entry, and dropped the execute-time
warning test. The other two changes (objects/prefix validation in
`GCSDeleteObjectsOperator` and destination fallbacks in
`GCSFileTransformOperator`) are unchanged.
---
Drafted-by: Claude Code (Fable 5) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
